Skip to content

OnChunkLoad memory leak or performance issue #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheTallestOfMidgets opened this issue Dec 20, 2021 · 12 comments
Open

OnChunkLoad memory leak or performance issue #237

TheTallestOfMidgets opened this issue Dec 20, 2021 · 12 comments
Labels
Bug Ono, a bug!

Comments

@TheTallestOfMidgets
Copy link

TheTallestOfMidgets commented Dec 20, 2021

Hello to whoever,
So after installing the latest release (at the time 4.2.1) the tps of the server began to slowly decline.
The server is running on a linux mint 20.2 vm with 8gb of ram and all the cpu usage it could use.
The other installed plugins are bettersleeping 4.0.0 and ebackup 1.3.0, both of which (with my understanding) should not interfere with any game mechanics that ImageOnMap does.

But I digress the plugin only seems to lower tps after a map has been created and then loaded in,
I would imagine this to be a memory leak due to the slow decline in tps and "/reload" temporarily fixing the problem.

The console only output's "moved too quickly" warnings due to the low tps.

I could attach I video demonstrating the issue if requested, although I believe it wont show more than what is described here

@FunOnABun72
Copy link

I'm having the same issue with my server. I'm using the same about of ram and the problem only started once I installed the latest version.

@Kyrillian
Copy link

I'm experiencing the same issue with ImageOnMap 4.2.1 on a CentOS machine using 12GB of RAM for the minecraft process.
Other plugins I used were WorldBorder and Dynmap.

restarting the server remedied the issue for a little bit. yet after a while the server kicks everyone off with a timeout.
I uninstalled all plugins one by one and the issue was fixed after uninstalling ImageOnMap.

I'd gladly be of service by posting logfiles if need be

@Vlammar
Copy link
Member

Vlammar commented Dec 25, 2021

Hello,
are you using paper or spigot?
What is your actual minecraft version?
Can you provide me a log using spark ? https://www.spigotmc.org/resources/spark.57242/ (It will help in investigating the source of your lag)

@Vlammar Vlammar added the Need info More info are needed label Dec 25, 2021
@TheTallestOfMidgets
Copy link
Author

@Vlammar I'm running spigot on Minecraft 1.18.1,
and in reference to spark: which what data are you looking for? (eg. Garbage collection, heap dump, memory usage, ect)

@Vlammar
Copy link
Member

Vlammar commented Dec 26, 2021

@TheTallestOfMidgets memory usage and CPU usafe of each threads is a good indicator for us to find what is causing lag :)
I have several ideas of what can be caussing your issue but no way to investigate nor test it.

@TheTallestOfMidgets
Copy link
Author

@Vlammar I have done what I believe are the proper tests:
profiler (Default): https://spark.lucko.me/4WXCV7gJx1
profiler (all threads): https://spark.lucko.me/5wVBfN3wKF
heap Summary: https://spark.lucko.me/rb9y9nxASo
latest.log
(my bad if any of this was done incorrectly, I'm not familiar with spark)

The map would not initially cause lag if it was loaded at server start up, after unloading however (by entering the nether) the server would consistently experience lag in both the overworld and nether. If need be I can upload the server files as well.

@Vlammar Vlammar added Bug Ono, a bug! and removed Need info More info are needed labels Dec 27, 2021
@Vlammar
Copy link
Member

Vlammar commented Dec 27, 2021

The culprite seems to be the event OnChunkLoad. They may have changed things, I will remove it if the player is in a version that is recent enough and see if that solve the issue (I won't be able to do it until the beginning of 2022).
Thanks for the help with the profiler+log :)

@TheTallestOfMidgets
Copy link
Author

Of course, thanks for being decently responsive

@AmauryCarrade AmauryCarrade changed the title Major TPS Issue OnChunkLoad memory leak or performance issue Jan 6, 2022
@DeJayDev
Copy link

DeJayDev commented Jan 7, 2022

Hello!

May I please ask you to verify your servers are running a Paper version higher than version 239?

@TheTallestOfMidgets
Copy link
Author

Hello @DeJayDev
My server is currently running the latest spigot build rather than paper

@Vlammar
Copy link
Member

Vlammar commented Jan 7, 2022

After some testing on the version 136 of paper I have no lag issue, I will try with the latest spigot version but the issue look to be caused by spigot/paper

@Kyrillian
Copy link

Hiya, just to let you know:

I've seen you guys write in the reviews and forums that an update from spigot fixed the issue in question.
I have updated to the latest stable spigot release yesterday and gave this addon another spin.

Sadly, the issue still persists.
When I create a map, everything is fine and dandy. Stable TPS at 20.
As soon as I place the map and put some strain on the server (I leave spawn and have chunks load in) it's lagging like crazy again. Deleting the addon fixes that.

If I can assist in any way, just let me know!
Thanks for maintaining this awesome addon!

@AmauryCarrade AmauryCarrade pinned this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Ono, a bug!
Projects
None yet
Development

No branches or pull requests

5 participants