Skip to content

Commit

Permalink
Remove leftover code bits about auth0
Browse files Browse the repository at this point in the history
Thanks to @GeorgianaElena's amazing work, we no longer
use auth0 for *anything*! This completely gets rid of the
code we wrote to support it.

YAY FOR GETTING RID OF CODE!
  • Loading branch information
yuvipanda committed Jun 1, 2023
1 parent ec2b26e commit 5c84f9c
Show file tree
Hide file tree
Showing 10 changed files with 74 additions and 462 deletions.
158 changes: 67 additions & 91 deletions deployer/README.md

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion deployer/__main__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Import the various subcommands here, they will be automatically
# registered into the app
import deployer.auth0_app # noqa: F401
import deployer.billing # noqa: F401
import deployer.cilogon_app # noqa: F401
import deployer.debug # noqa: F401
Expand Down
278 changes: 0 additions & 278 deletions deployer/auth0_app.py

This file was deleted.

3 changes: 1 addition & 2 deletions docs/contributing/code-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ To deploy changes to the authentication workflow, follow these steps:
1. **Manually deploy changes to a few kinds of staging hubs**. The hubs use different authentication mechanisms, based on their needs, but testing on the staging hubs listed below should cover all the possible types. The hubs are:
- cluster: `leap`, hub: `staging` (GitHub)
- cluster: `utoronto`, hub: `staging` (Azure AD)
- cluster: `2i2c`, hub: `staging` (Auth0)
- cluster: `2i2c`, hub: `demo` (CILogon)
- cluster: `2i2c`, hub: `staging` (CILogon)
1. **Login into the staging hubs**. Try logging in into the hubs where you deployed your changes.
1. **Start a server**. Afer you've logged into the hub, make sure everything works as expected by spinning up a server.
1. **Post the status of the manual steps above**. In your PR's top comment, post the hubs where you've deployed the changes and whether or not they are functioning properly.
Expand Down
72 changes: 0 additions & 72 deletions docs/hub-deployment-guide/configure-auth/auth0.md

This file was deleted.

1 change: 0 additions & 1 deletion docs/hub-deployment-guide/configure-auth/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ Switching authentication providers (e.g. from GitHub to Google) for a pre-existi
:caption: Authentication Providers
github-orgs
cilogon
auth0
```
4 changes: 0 additions & 4 deletions docs/hub-deployment-guide/hubs/other-hub-ops/delete-hub.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ kubectl delete namespace $HUB_NAME

## 4. Delete the OAuth application

### Auth0 OAuth application

For each hub that uses Auth0, we create an [Application](https://auth0.com/docs/applications) in Auth0. There is a limited number of Auth0 applications available, so we should delete the one used by this hub when it's done. You should be able to see the [list of applications](https://manage.auth0.com/dashboard/us/2i2c/applications) if you login to auth0 with your 2i2c google account.

### GitHub OAuth application

For each hub that uses the JupyterHub GitHubOAuthenticator, we create a GitHub [OAuth Application](https://docs.github.com/en/developers/apps/building-oauth-apps/creating-an-oauth-app). You should be able to see the [list of applications created under the `2i2c` GitHub org](https://github.com/organizations/2i2c-org/settings/applications) and delete the one created for the hub that's being decommissioned.
Expand Down
1 change: 0 additions & 1 deletion docs/topic/infrastructure/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ for each hub.
| - | - | - |
| Upstream defaults from z2jh | z2jh maintainers | [`helm-charts/basehub/Chart.yaml`](https://github.com/2i2c-org/infrastructure/tree/HEAD/helm-charts/basehub/Chart.yaml) lists the z2jh version. Most of our configuration is directly from upstream |
| [`helm-charts/basehub/values.yaml`](https://github.com/2i2c-org/infrastructure/tree/HEAD/helm-charts/basehub/values.yaml) | 2i2c engineers | Common to all hubs run from this repo |
| [Deployment script](https://github.com/2i2c-org/infrastructure/tree/HEAD/deployer) | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration and home page customization |
| [`config/clusters` (previously `hubs.yaml`)](https://github.com/2i2c-org/infrastructure/tree/HEAD/config/clusters) | 2i2c engineers | There is one folder per cluster, and each cluster can have multiple hubs deployed defined by a `<hub_name>.values.yaml` file in the same folder. There is also cluster-wide config stored in a `cluster.yaml` in each cluster directory. [`config/clusters/schema.yaml`](https://github.com/2i2c-org/infrastructure/blob/HEAD/deployer/cluster.schema.yaml) contains documentation and validation information for fields in this set of configuration. |
| [Configurator schema defaults](https://github.com/2i2c-org/infrastructure/tree/HEAD/helm-charts/basehub/values.yaml#L143) | 2i2c engineers | **If** there is a default set in the schema for available options in the configurator, it will always override the config elsewhere in our YAML files |
| Configurator | Hub admins | If hub admins 'unset' a value, it should go to what's configured via our yaml files|
Expand Down
2 changes: 0 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,3 @@ gspread==5.9.*
# requests is used by deployer/cilogon_app.py
requests==2.*

# auth0 is used to communicate with Auth0's REST API that we support as a deployer sub-cmd
auth0-python==3.*
Loading

0 comments on commit 5c84f9c

Please sign in to comment.