Skip to content

Commit 480d755

Browse files
committed
[#9804] Add Python type annotations to the Spark test runner
Summary: Add Python type annotations to the Spark test runner. Also use the codecheck tool to verify a subset of Python scripts during the build. Test Plan: Jenkins: build type: release Reviewers: jharveysmith, steve.varnau Reviewed By: steve.varnau Subscribers: ybase Differential Revision: https://phabricator.dev.yugabyte.com/D12701
1 parent 8ee03e7 commit 480d755

10 files changed

+282
-149
lines changed

bin/run_codecheck

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#!/usr/bin/env bash
2+
3+
set -euo pipefail
4+
. "${BASH_SOURCE%/*}/../build-support/common-build-env.sh"
5+
6+
activate_virtualenv
7+
set_pythonpath
8+
9+
codecheck "$@"

build-support/common-test-env.sh

+3-1
Original file line numberDiff line numberDiff line change
@@ -1850,11 +1850,13 @@ run_python_doctest() {
18501850

18511851
run_python_tests() {
18521852
activate_virtualenv
1853+
check_python_script_syntax
18531854
(
18541855
export PYTHONPATH=$YB_SRC_ROOT/python
18551856
run_python_doctest
1857+
log "Invoking the codecheck tool"
1858+
python3 -m codecheck
18561859
)
1857-
check_python_script_syntax
18581860
}
18591861

18601862
should_run_java_test_methods_separately() {

0 commit comments

Comments
 (0)