[ENG-2644] HMSet should not return int response for one subkey

Summary: We use a flag expect_int_response in the proto instead of number of subkeys in the array.

Test Plan: redisserver-test

Reviewers: amitanand

Reviewed By: amitanand

Subscribers: eng, kannan

Differential Revision: https://phabricator.dev.yugabyte.com/D3724

Author: Akashnil

src/yb/common/redis_protocol.proto

@@ -139,6 +139,7 @@ message RedisKeyValuePB {
 
 // SET, SETNX, SETXX, HSET, HSETNX, LSET, MSET, HMSET, MSETNX
 message RedisSetRequestPB {
+  optional bool expect_ok_response = 1 [ default = false ];
   optional int64 ttl = 2;                  // Expiry time in milliseconds.
   optional RedisWriteMode mode = 3 [ default = REDIS_WRITEMODE_UPSERT ];
 }

src/yb/docdb/doc_operation.cc

@@ -504,7 +504,8 @@ Status RedisWriteOperation::ApplySet(const DocOperationApplyData& data) {
         // For an HSET command (which has only one subkey), we need to read the subkey to find out
         // if the key already existed, and return 0 or 1 accordingly. This read is unnecessary for
         // HMSET and TSADD.
-        if (kv.subkey_size() == 1 && EmulateRedisResponse(kv.type())) {
+        if (kv.subkey_size() == 1 && EmulateRedisResponse(kv.type()) &&
+            !request_.set_request().expect_ok_response()) {
           auto type = GetValueType(data, 0);
           RETURN_NOT_OK(type);
           // For HSET/TSADD, we return 0 or 1 depending on if the key already existed.

src/yb/yql/redis/redisserver/redis_parser.cc

@@ -174,6 +174,10 @@ CHECKED_STATUS ParseHMSetLikeCommands(YBRedisWriteOp *op, const RedisClientComma
   op->mutable_request()->mutable_key_value()->set_type(type);
   op->mutable_request()->mutable_key_value()->set_key(args[1].cdata(), args[1].size());
 
+  if (type == REDIS_TYPE_HASH) {
+    op->mutable_request()->mutable_set_request()->set_expect_ok_response(true);
+  }
+
   std::unordered_map<string, string> kv_map;
   for (int i = 2; i < args.size(); i += 2) {
     // EXPIRE_AT/EXPIRE_IN only supported for redis timeseries currently.

src/yb/yql/redis/redisserver/redisserver-test.cc

@@ -1404,6 +1404,9 @@ TEST_F(TestRedisService, TestTimeSeriesTTL) {
       "4", "v400",
       "5", "v500",
   });
+  DoRedisTestOk(__LINE__, {"HMSET", "map_key",
+      "6", "v600"
+  });
   DoRedisTestOk(__LINE__, {"SET", "key", "value"});
   SyncClient();
   DoRedisTestExpectError(__LINE__, {"TSRANGEBYTIME" , "map_key", "1", "5"});