Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows notification shows wrong thumbnail #1318

Open
2 tasks done
R00TEAD0 opened this issue Feb 19, 2024 · 3 comments
Open
2 tasks done

Windows notification shows wrong thumbnail #1318

R00TEAD0 opened this issue Feb 19, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@R00TEAD0
Copy link

Consent

  • I verified that there is no open/closed issue for the same subject.
  • I understand that YTMDesktop have NO affiliation with Google or YouTube

Current Behavior

Hi there, recently I noticed that notifications on Windows (Windows 11 in my case) show the previous thumbnail instead of the 'playing now' song

image

Expected Behavior

It's a bug so I only want to show it and if possible, contribute to solving it.

Steps To Reproduce

  1. Play a song
  2. Go to the next or previous song
  3. And voila! Maybe...the

YTMDesktop

2.0.0

OS

Windows

OS Version

11

Arch

x64

Installation way

.exe

Anything else?

No response

@Alipoodle
Copy link
Member

This is something I've been meaning to diagnose.
During the 4 months of running a test build I never had this happen, but as soon as we went live it happened.

@R00TEAD0
Copy link
Author

I just saw it today. Because I don't know much about TypeScrypt I'm just speculating according to the syntax. It may be related to how the notifications are shown and the async method that manages the notification process (Maybe some variable that stacks on previous data or something similar after the async function is executed). I will try one of the RC versions to check if the behavior extends to those or not.

@NovusTheory
Copy link
Member

This is occurring because we can't obtain the artwork immediately which leads it to being delayed and the state of the song may already be playing before the artwork is received which is causing the notification to show. Unfortunately there's nothing we can do to fix that as YTM doesn't provide it immediately with the rest of the video data. This is part of a broader needed change to help alleviate this. Notifications are probably stuck with needing weird hacky fixes to get around that and they won't be perfect especially if you rely on artwork always existing.

@Alipoodle Alipoodle added the Bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants