New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match-title/reject-title inconsistent with match-filter/documentation #9766
Comments
The documentation states that
It is a deprecated option - hence why it is not fully documented anymore. The docs instead give you the equivalent modern option which should preferably be used.
I don't understand what you are saying here. --match-filter does already support both |
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Provide a description that is worded well enough to be understood
I am not sure whether this is a documentation issue or a bug, but it doesn't fit together this way:
--match-title REGEX
is equivalent to--match-filter "title ~= (?i)REGEX"
--reject-title REGEX
is equivalent to--match-filter "title !~= (?i)REGEX"
--match-filters FILTER
(what's the s doing there? It's not in the description. Typo?) states: "If used multiple times" there is a disjunction of the filters.From the description I would expect to be able to use
--match-title
multiple times, but only the last instance is actually applied (seeyt-dlp/yt_dlp/options.py
Lines 596 to 599 in 89f535e
yt-dlp/yt_dlp/YoutubeDL.py
Line 1471 in 89f535e
But even if this were the case that multiple
--match-title
statements actually translate to multiple--match-filter
statements, this then works unintuitively for the--reject-title
case which probably does not work as a disjunction and would download the file if any of the patterns does not match the title (or alternatively, only rejects the video if all reject-patterns match).I propose the following courses of action:
--reject-title
and--match-title
can only be used once each and are and-combined instead of or-combined (and that their behaviour is therefore, at least in combination, not equivalent to the stated--match-filter
code).--reject-title
and--match-title
arguments should be combined and in combination be converted into single--match-filter
statement with one of the following semantics:(DISJUNCTION --match-title) AND (CONJUNCTION --reject-titles)
, or(CONJUNCTION --match-title) AND (CONJUNCTION --reject-titles)
.--match-title
. But for multiple--reject-title
appearances, the conjunction is the intuitive semantics here.The first proposal has the virtue of solidifying what's actually been done in code. The second proposal provides an intuitive interface for title matching and would be more in correspondence to what's currently stated in the documentation.
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)'verbose': True
toYoutubeDL
params instead[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: