Does -S option have error checking?

[stdedos]

Reading

# Download the best video with the best extension
# (For video, mp4 > webm > flv. For audio, m4a > aac > mp3 ...)
$ yt-dlp -S 'ext'

I assumed the 'ext' was a placeholder (since, technically, there was no need to add it into quotes).

So, I imagine my surprise when I did youtube-dl -S mp4 ... and I saw "Destination ... .webm".

I was wondering: does yt-dlp have error checking in the -S function? Or does "mp4" mean something?

[pukkandan]

does yt-dlp have error checking in the -S function

It does check the syntax. But there is no validation of the fields themselves. This is because it was designed to work with any arbitrary field. Thinking back on it now, it was probably a bad design choice to do that.

I have been meaning to refactor the entire FormatSort code in the future. When I do, I'll see what can be done to improve the validation

I assumed the 'ext' was a placeholder (since, technically, there was no need to add it into quotes).

all examples are literal

[stdedos]

Aaah, I see now. Sounds like a hell of a behavior to tackle.

Thanks! 🎉

[pukkandan]

Now a warning is issued in such cases

[stdedos]

Commit/Issue/PR ID? 😄

[pukkandan]

It was part of ee8dd27

The idea is to eventually throw error for these. Once that is done, validation logic can be added to option parsing itself

[stdedos]

Hopefully, they will not be missed 🙏

[KaranTrivedi]

Sorry to comment here, is there a way to create a new discussion? I wanted to learn more about hooks. I use the lib in fastapi, and would like to return the progress_hooks to the front end so I can track download progress in maybe an angular/react UI or something. Is this possible? What is the best way to do this?

[pukkandan]

See this example. For further questions, open an issue