Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository misconfiguration: test Actions workflow should not require PR approval #399

Open
binury opened this issue Apr 13, 2024 · 0 comments

Comments

@binury
Copy link

binury commented Apr 13, 2024

As this repository is currently configured —as of at least 5 months ago— the CI/Action test step will pragmatically1 never run for PRs, until they are already approved or merged. This arguably defeats the purpose and passing CI should be a requisite for approval— not something that happens after review approval. The test action is essentially no longer running.

https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/settings/actions
ss 2024-04-13 at 13 09 14@2x

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories

Footnotes

  1. Last PR workflow ran 5 months ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant