-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ruff linter #1134
Comments
👋 Hi @jxdv, |
Totally agree with that |
Do you have experience with that? I don't, but I could look into it when I have more time. |
I can create a PR for this if you're interested, but the refactoring obviously would have to be a team effort. It's gonna take quite some time. |
If you can, yes please. Don't forget to use the closing keywords for this issue. But wait, doesn't this GitHub Action refactor the entire codebase by itself? In other words: it doesn't need to be done manually, right? From what I'm understanding of the repo, that is. |
Yes, Ruff can fix some stuff by itself using |
@AnonymousWP I am wondering how would you like to see the linked PRs to this..1 PR just for the implementation of Ruff itself, and the second one for the big python cleanup? |
Yep, correct. Maybe a separate issue to refactor the code and then link the PR of the big Python cleanup to it. |
Is there an existing feature or issue for this?
Expected feature
Currently the styling of the python codebase is inconsistent. Some examples:
Proposed solution:
Writing a GitHub action for Ruff linter. Of course this would take quite a while to refactor the whole codebase, but I can see the project benefitting from it.
Alternative solutions
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: