Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS2322 not rendered correctly #105

Closed
moritz-t-w opened this issue Apr 30, 2024 · 2 comments · Fixed by #106
Closed

TS2322 not rendered correctly #105

moritz-t-w opened this issue Apr 30, 2024 · 2 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@moritz-t-w
Copy link

Describe the bug
ts(2322) is rendererd partly wrong at the end.
These are the relevant properties

#overlaps!: OverlapConfigurationParameters[];
private async download(file: File<string | MpcdiZip>): Promise<void>

Expected behavior
each property listed gets its own bullet point

Original error

Type 'Ref<{ name: string; readonly type: "json"; mm: <T extends Convertible = Convertible>(px: T) => T; px: <T extends Convertible = Convertible>(mm: T) => T; ... 18 more ...; toJson: () => string; }>' is not assignable to type 'Ref<MpcdiConfiguration>'.
  Type '{ name: string; readonly type: "json"; mm: <T extends Convertible = Convertible>(px: T) => T; px: <T extends Convertible = Convertible>(mm: T) => T; ... 18 more ...; toJson: () => string; }' is missing the following properties from type 'MpcdiConfiguration': ratio, #overlaps, download

Screenshots
Screenshot from 2024-04-30 08-16-06

is missing the following properties from type MpcdiConfiguration:

  • ratio,
    #overlaps, download
@moritz-t-w moritz-t-w added the bug Something isn't working label Apr 30, 2024
@kevinramharak kevinramharak mentioned this issue May 7, 2024
Merged
@kevinramharak
Copy link
Contributor

Issue is the private property prefix character #, I submitted a PR #106

@yoavbls
Copy link
Owner

yoavbls commented May 18, 2024

Thank you, the fix will be there in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: adjust missing props regex to work for private properties kevinramharak/pretty-ts-errors
3 participants
@yoavbls @kevinramharak @moritz-t-w