Merge pull request #13 from ynput/bugfix/AY-4222_3dsMax-Multicam-uses-the-same-camera

Make sure multicamera render uses correct camera

Author: moonyuet

client/ayon_max/api/lib_renderproducts.py

@@ -40,6 +40,7 @@ def get_beauty(self, container):
     def get_multiple_beauty(self, outputs, cameras):
         beauty_output_frames = dict()
         for output, camera in zip(outputs, cameras):
+            camera = camera.replace(":", "_")
             filename, ext = os.path.splitext(output)
             filename = filename.replace(".", "")
             ext = ext.replace(".", "")
@@ -59,6 +60,7 @@ def get_multiple_aovs(self, outputs, cameras):
         renderer = str(renderer_class).split(":")[0]
         aovs_frames = {}
         for output, camera in zip(outputs, cameras):
+            camera = camera.replace(":", "_")
             filename, ext = os.path.splitext(output)
             filename = filename.replace(".", "")
             ext = ext.replace(".", "")

client/ayon_max/api/lib_rendersettings.py

@@ -181,6 +181,7 @@ def get_batch_render_elements(self, container,
         for i in range(render_elem_num):
             renderlayer_name = render_elem.GetRenderElement(i)
             target, renderpass = str(renderlayer_name).split(":")
+            camera = camera.replace(":", "_")
             aov_name = f"{output}_{camera}_{renderpass}..{img_fmt}"
             render_element_list.append(aov_name)
         return render_element_list
@@ -222,6 +223,7 @@ def batch_render_layer(self, container,
                 renderlayer = rt.batchRenderMgr.GetView(layer_no)
             # use camera name as renderlayer name
             renderlayer.name = cam
+            cam = cam.replace(":", "_")
             renderlayer.outputFilename = f"{output}_{cam}..{img_fmt}"
             outputs.append(renderlayer.outputFilename)
         return outputs

client/ayon_max/plugins/publish/collect_render.py

@@ -67,7 +67,6 @@ def process(self, instance):
             instance.data["files"] = list()
             instance.data["expectedFiles"].append(files_by_aov)
             instance.data["files"].append(files_by_aov)
-
         img_format = RenderProducts().image_format()
         # OCIO config not support in
         # most of the 3dsmax renderers

client/ayon_max/plugins/publish/save_scenes_for_cameras.py

@@ -1,8 +1,10 @@
 import pyblish.api
 import os
 import sys
+import platform
 import tempfile
 
+
 from pymxs import runtime as rt
 from ayon_core.lib import run_subprocess
 from ayon_max.api.lib_rendersettings import RenderSettings
@@ -41,7 +43,8 @@ def process(self, instance):
         for camera in cameras:
             new_output = RenderSettings().get_batch_render_output(camera)       # noqa
             new_output = new_output.replace("\\", "/")
-            new_filename = f"{filename}_{camera}{ext}"
+            camera_name = camera.replace(":", "_")
+            new_filename = f"{filename}_{camera_name}{ext}"
             new_filepath = os.path.join(new_folder, new_filename)
             new_filepath = new_filepath.replace("\\", "/")
             camera_scene_files.append(new_filepath)
@@ -55,17 +58,22 @@ def process(self, instance):
 new_filepath = "{new_filepath}"
 new_output = "{new_output}"
 camera = "{camera}"
+camera_name = camera.replace(":", "_")
+target_camera_node = rt.getNodeByName(camera)
+rt.viewport.setCamera(target_camera_node)
 rt.rendOutputFilename = new_output
 directory = os.path.dirname(rt.rendOutputFilename)
 directory = os.path.join(directory, filename)
+if not os.path.exists(directory):
+    os.mkdir(directory)
 render_elem = rt.maxOps.GetCurRenderElementMgr()
 render_elem_num = render_elem.NumRenderElements()
 if render_elem_num > 0:
     ext = "{ext}"
     for i in range(render_elem_num):
         renderlayer_name = render_elem.GetRenderElement(i)
         target, renderpass = str(renderlayer_name).split(":")
-        aov_name =  f"{{directory}}_{camera}_{{renderpass}}..{ext}"
+        aov_name =  f"{{directory}}_{{camera_name}}_{{renderpass}}..{ext}"
         render_elem.SetRenderElementFileName(i, aov_name)
 rt.saveMaxFile(new_filepath)
         """).format(filename=instance.name,
@@ -74,11 +82,10 @@ def process(self, instance):
                     camera=camera,
                     ext=fmt)
             scripts.append(script)
-
         maxbatch_exe = os.path.join(
             os.path.dirname(sys.executable), "3dsmaxbatch")
         maxbatch_exe = maxbatch_exe.replace("\\", "/")
-        if sys.platform == "windows":
+        if platform.system().lower() == "windows":
             maxbatch_exe += ".exe"
             maxbatch_exe = os.path.normpath(maxbatch_exe)
         with tempfile.TemporaryDirectory() as tmp_dir_name:
@@ -90,16 +97,18 @@ def process(self, instance):
                 for script in scripts:
                     tmp.write(script + "\n")
 
-            try:
-                current_filepath = current_filepath.replace("\\", "/")
-                tmp_script_path = tmp_script_path.replace("\\", "/")
-                run_subprocess([maxbatch_exe, tmp_script_path,
-                                "-sceneFile", current_filepath])
-            except RuntimeError:
-                self.log.debug("Checking the scene files existing")
+            full_script = "\n".join(scripts)
+            self.log.debug(f"Failed running script {tmp_script_path}:\n{full_script}")
+            current_filepath = current_filepath.replace("\\", "/")
+            tmp_script_path = tmp_script_path.replace("\\", "/")
+            run_subprocess([maxbatch_exe, tmp_script_path,
+                            "-sceneFile", current_filepath],
+                            logger=self.log)
 
         for camera_scene in camera_scene_files:
             if not os.path.exists(camera_scene):
+                full_script = "\n".join(scripts)
+                self.log.debug(f"Failed running script {tmp_script_path}:\n{full_script}")
                 self.log.error("Camera scene files not existed yet!")
                 raise RuntimeError("MaxBatch.exe doesn't run as expected")
             self.log.debug(f"Found Camera scene:{camera_scene}")