Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: error occurred when selected span in log details does not exist #83

Open
ymtdzzz opened this issue Jun 28, 2024 · 1 comment
Open

Comments

@ymtdzzz
Copy link
Owner

ymtdzzz commented Jun 28, 2024

Currently, selecting a deleted trace id shows strange view.

Image

Blocked by: #84

@ymtdzzz ymtdzzz added this to otel-tui Jun 28, 2024
@ymtdzzz ymtdzzz converted this from a draft issue Jun 28, 2024
@ymtdzzz ymtdzzz moved this from Todo to In Progress in otel-tui Jun 28, 2024
@ymtdzzz
Copy link
Owner Author

ymtdzzz commented Jun 28, 2024

The error No spans found should be handled in:

func DrawTimeline(traceID string, tcache *telemetry.TraceCache, lcache *telemetry.LogCache, setFocusFn func(p tview.Primitive)) (tview.Primitive, KeyMaps) {
if traceID == "" || tcache == nil {
return newTextView("No spans found"), KeyMaps{}
}
_, ok := tcache.GetSpansByTraceID(traceID)
if !ok {
return newTextView("No spans found"), KeyMaps{}
}

But to do this, there must be a way to back to the previous page in DrawTimeline() so this issue is blocked by #84 .

@ymtdzzz ymtdzzz moved this from In Progress to Todo in otel-tui Jun 28, 2024
@ymtdzzz ymtdzzz removed the status in otel-tui Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant