Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop junk spans #195

Open
codefromthecrypt opened this issue Jan 15, 2025 · 4 comments
Open

drop junk spans #195

codefromthecrypt opened this issue Jan 15, 2025 · 4 comments

Comments

@codefromthecrypt
Copy link

when envoy isn't configured properly and health checks are on, you'll get a bunch of traces you never want to see that have values like this:

http.url: https://arch_prompt_gateway_listener/healthz

It would be nice to have a way to by default drop any traces with a http.url ending in /healthz or similar patterns, so that it is easier to use the tool even when tracing of nodes isn't ideal

@ymtdzzz
Copy link
Owner

ymtdzzz commented Jan 16, 2025

Thanks for your suggestion. That sounds great! Are you thinking of some kind of startup option like --ignore health?

@codefromthecrypt
Copy link
Author

I was thinking to ignore them by default and have an arg to override (possibly zero out) the skip URL pattern

@ymtdzzz
Copy link
Owner

ymtdzzz commented Jan 26, 2025

I see, but as a development tool, isn't there a risk of user confusion if there is a telemetry that is implicitly dropped by default?

@codefromthecrypt
Copy link
Author

agree it is a choice between annoyance and config, vs a chance someone will care about not seeing /health and then be annoyed at lack of config ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants