-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop junk spans #195
Comments
Thanks for your suggestion. That sounds great! Are you thinking of some kind of startup option like |
I was thinking to ignore them by default and have an arg to override (possibly zero out) the skip URL pattern |
I see, but as a development tool, isn't there a risk of user confusion if there is a telemetry that is implicitly dropped by default? |
agree it is a choice between annoyance and config, vs a chance someone will care about not seeing /health and then be annoyed at lack of config ;) |
when envoy isn't configured properly and health checks are on, you'll get a bunch of traces you never want to see that have values like this:
It would be nice to have a way to by default drop any traces with a http.url ending in /healthz or similar patterns, so that it is easier to use the tool even when tracing of nodes isn't ideal
The text was updated successfully, but these errors were encountered: