fix: cache:modify command also needs new formatted cache type descriptions

Author: carlalexander

src/Command/Cache/AbstractCacheCommand.php

@@ -13,6 +13,7 @@
 
 namespace Ymir\Cli\Command\Cache;
 
+use Illuminate\Support\Collection;
 use Symfony\Component\Console\Exception\RuntimeException;
 use Ymir\Cli\Command\AbstractCommand;
 use Ymir\Cli\Exception\InvalidInputException;
@@ -43,4 +44,14 @@ protected function determineCache(string $question): array
 
         return $cache;
     }
+
+    /**
+     * Get the descriptions of the cache types for a given provider and engine.
+     */
+    protected function getCacheTypeDescriptions(int $providerId, string $engine): Collection
+    {
+        return $this->apiClient->getCacheTypes($providerId)->map(function (array $details) use ($engine) {
+            return sprintf('%s vCPU, %sGiB RAM (~$%s/month)', $details['cpu'], $details['ram'], $details['price'][$engine]);
+        });
+    }
 }

src/Command/Cache/CreateCacheCommand.php

@@ -17,12 +17,11 @@
 use Symfony\Component\Console\Exception\RuntimeException;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputOption;
-use Ymir\Cli\Command\AbstractCommand;
 use Ymir\Cli\Exception\CommandCancelledException;
 use Ymir\Cli\Exception\InvalidInputException;
 use Ymir\Cli\Project\Configuration\CacheConfigurationChange;
 
-class CreateCacheCommand extends AbstractCommand
+class CreateCacheCommand extends AbstractCacheCommand
 {
     /**
      * The name of the command.
@@ -88,9 +87,7 @@ private function determineType(Collection $network, string $engine): string
         }
 
         $type = $this->input->getStringOption('type');
-        $types = $this->apiClient->getCacheTypes((int) $network['provider']['id'])->map(function (array $details) use ($engine) {
-            return sprintf('%s vCPU, %sGiB RAM (~$%s/month)', $details['cpu'], $details['ram'], $details['price'][$engine]);
-        });
+        $types = $this->getCacheTypeDescriptions((int) $network['provider']['id'], $engine);
 
         if (null !== $type && !$types->has($type)) {
             throw new InvalidInputException(sprintf('The type "%s" isn\'t a valid cache cluster type', $type));

src/Command/Cache/ModifyCacheCommand.php

@@ -45,7 +45,7 @@ protected function perform()
     {
         $cache = $this->determineCache('Which cache cluster would you like to modify');
         $type = $this->input->getStringOption('type', true);
-        $types = $this->apiClient->getCacheTypes($cache['provider']['id']);
+        $types = $this->getCacheTypeDescriptions($cache['provider']['id'], $cache['engine']);
 
         if (null === $type) {
             $type = $this->output->choice(sprintf('What should the cache cluster type be changed to? <fg=default>(Currently: <comment>%s</comment>)</>', $cache['type']), $types);