Fix @var annotation for Response::$statusCode and @return annotation for Response::getStatusCode()

Author: mspirkov

phpstan-baseline.neon

@@ -660,12 +660,6 @@ parameters:
 			count: 1
 			path: src/Response.php
 
-		-
-			message: '#^Method yii\\httpclient\\Response\:\:getStatusCode\(\) should return string but returns string\|null\.$#'
-			identifier: return.type
-			count: 1
-			path: src/Response.php
-
 		-
 			message: '#^Method yii\\httpclient\\StreamTransport\:\:composeContextOptions\(\) has parameter \$options with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue
@@ -1056,12 +1050,6 @@ parameters:
 			count: 1
 			path: tests/ResponseTest.php
 
-		-
-			message: '#^Method yiiunit\\extensions\\httpclient\\ResponseTest\:\:dataProviderIsOk\(\) return type has no value type specified in iterable type array\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: tests/ResponseTest.php
-
 		-
 			message: '#^Method yiiunit\\extensions\\httpclient\\ResponseTest\:\:dataProviderParseBody\(\) return type has no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/Response.php

@@ -15,7 +15,7 @@
  * Response represents HTTP request response.
  *
  * @property-read bool $isOk Whether response is OK.
- * @property-read string $statusCode Status code.
+ * @property-read string|null $statusCode Status code.
  *
  * @author Paul Klimov <klimov.paul@gmail.com>
  * @since 2.0
@@ -56,7 +56,7 @@ public function getCookies()
     /**
      * Returns status code.
      * @throws Exception on failure.
-     * @return string status code.
+     * @return string|null status code.
      */
     public function getStatusCode()
     {

tests/ResponseTest.php

@@ -171,16 +171,13 @@ public function testGetStatusCode(): void
     {
         $response = new Response();
 
-        $statusCode = 123;
+        $statusCode = '123';
         $response->setHeaders(['http-code' => $statusCode]);
-        $this->assertEquals($statusCode, $response->getStatusCode());
+        $this->assertSame($statusCode, $response->getStatusCode());
 
-        $statusCode = 123;
-        $response->setHeaders(['http-code' => [
-            $statusCode + 10,
-            $statusCode,
-        ]]);
-        $this->assertEquals($statusCode, $response->getStatusCode());
+        $statusCode = '123';
+        $response->setHeaders(['http-code' => ['133', $statusCode]]);
+        $this->assertSame($statusCode, $response->getStatusCode());
     }
 
     public function testUnableToGetStatusCode(): void
@@ -194,31 +191,28 @@ public function testUnableToGetStatusCode(): void
 
     /**
      * Data provider for [[testIsOk()]]
-     * @return array test data.
+     * @return list<array{string, bool}> test data.
      */
     public function dataProviderIsOk(): array
     {
         return [
-            [100, false],
-            [200, true],
-            [201, true],
-            [226, true],
-            [400, false],
+            ['100', false],
+            ['200', true],
+            ['201', true],
+            ['226', true],
+            ['400', false],
         ];
     }
 
     /**
      * @dataProvider dataProviderIsOk
      * @depends      testGetStatusCode
-     *
-     * @param int $statusCode
-     * @param bool $isOk
      */
-    public function testIsOk($statusCode, $isOk): void
+    public function testIsOk(string $statusCode, bool $isOk): void
     {
         $response = new Response();
         $response->setHeaders(['http-code' => $statusCode]);
-        $this->assertEquals($isOk, $response->getIsOk());
+        $this->assertSame($isOk, $response->getIsOk());
     }
 
     public function testParseCookieHeader(): void