Skip to content

EnumTypeCaster by default#107

Open
sunnyphp wants to merge 2 commits into
yiisoft:masterfrom
sunnyphp:master
Open

EnumTypeCaster by default#107
sunnyphp wants to merge 2 commits into
yiisoft:masterfrom
sunnyphp:master

Conversation

@sunnyphp
Copy link
Copy Markdown
Contributor

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Hello.

I suggest using EnumTypeCaster by default, since enumerations are, in my opinion, heavily used by developers. I also provided an example in readme.md for clarity.

Thanks.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (067f551) to head (604d33d).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #107   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       332       332           
===========================================
  Files             43        43           
  Lines            827       828    +1     
===========================================
+ Hits             827       828    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik
Copy link
Copy Markdown
Member

vjik commented Jun 18, 2025

You are right, but I think this break backward compatibility. I suggest merge it before major release.

@sunnyphp Can you extract the doc fixes into a separate PR?

@vjik vjik added the severity:BC breaking Breaks backwards compatibility label Jun 18, 2025
@vjik vjik added this to the 2.0 milestone Jun 18, 2025
@sunnyphp
Copy link
Copy Markdown
Contributor Author

sunnyphp commented Jun 18, 2025

You are right, but I think this break backward compatibility. I suggest merge it before major release.

Fully agree.

@sunnyphp Can you extract the doc fixes into a separate PR?

Done. #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity:BC breaking Breaks backwards compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants