EnumTypeCaster by default#107
Open
sunnyphp wants to merge 2 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 332 332
===========================================
Files 43 43
Lines 827 828 +1
===========================================
+ Hits 827 828 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
You are right, but I think this break backward compatibility. I suggest merge it before major release. @sunnyphp Can you extract the doc fixes into a separate PR? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I suggest using
EnumTypeCasterby default, since enumerations are, in my opinion, heavily used by developers. I also provided an example inreadme.mdfor clarity.Thanks.