-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bacth actions job validations for numberlists #1276
Labels
Comments
@dmitry-sinina Hi, I have a question related to the current issue. Technically we can nullify column |
Ivanov-Anton
pushed a commit
to Ivanov-Anton/yeti-web
that referenced
this issue
Oct 20, 2023
The dependent action for src_customers_auths and dst_customers_auths in the numberlist model has been changed from restrict_with_error to nullify. This was to allow for deletion of a numberlist item even when it has related customer_auths. Corresponding test cases have been added to ensure expected behavior.
Ivanov-Anton
pushed a commit
to Ivanov-Anton/yeti-web
that referenced
this issue
Oct 20, 2023
…y and resilience The AsyncBatchDestroyJob has been refactored to utilise Rails's `find_in_batches` method as opposed to a custom SQL query. This proves to make the process of record deletion both more efficient and more resilient to database inconsistencies. Previously, records that could not be deleted due to dependencies would raise an exception, breaking the whole transaction. Now, these records are logged and skipped over instead. Updates to associated tests have been made to verify and reflect these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: