Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove https://platform.twitter.com/widgets.js from the site #852

Open
JoshuaKGoldberg opened this issue Jan 27, 2025 · 3 comments
Open

Comments

@JoshuaKGoldberg
Copy link
Contributor

Following #845, the https://platform.twitter.com/widgets.js script is still loaded on the site:

$script("https://platform.twitter.com/widgets.js");

I think we can get rid of this, right?

@UlisesGascon
Copy link
Member

✅ I think so... seems like social part is covered by https://github.com/yeoman/yeoman.io/blob/main/app/_includes/social.html with specific scripts (that can be refactored)

@eddiemonge
Copy link
Member

I would say even removing the social share buttons is acceptable as people have other ways to share, often built in to the browser or OS so having the site do it is outdated.

@JoshuaKGoldberg
Copy link
Contributor Author

+1 from me on using the browser/OS but -1 on removing buttons altogether. Having a nice little call-to-action on the page IME does increase the frequency of folks sharing the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants