New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should npm run script check
run after test
?
#141
Comments
Currently the check is a bit noisy due to dependencies. Might be a good time to make this change when drop node 12 and update dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some minor benefits to having the lint check separate from the runtime tests, so that more of the GitHub Action checks complete and aren't blocked by lint issues. However, makes it easy to open a PR and push code that will fail on the lint check.
I noticed there is
postest
run script, which should presumably beposttest
! Leaning towards enabling that as I tend to only fix one breakage at a time anyway.cliui/package.json
Line 23 in af3145d
Fixing that would render this line obsolete:
cliui/.github/workflows/ci.yaml
Line 24 in af3145d
The text was updated successfully, but these errors were encountered: