Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOT_SET_KCUBEMMIPARAMS (0x0520) has additional values #5

Open
ksunden opened this issue Jul 27, 2022 · 0 comments
Open

MOT_SET_KCUBEMMIPARAMS (0x0520) has additional values #5

ksunden opened this issue Jul 27, 2022 · 0 comments

Comments

@ksunden
Copy link
Member

ksunden commented Jul 27, 2022

Migrated from https://gitlab.com/yaq/thorlabs-apt-protocol/-/issues/9 opened by myself

Recent versions of the protocol introduced PreSetPos3 and JSSensitivity, added on to the end of 0x520 and 0x522 (set/get) for the kcubemmiparams command. (and two trailing "Reserved" bytes, but I think that can be safely ignored for the time being)

These are documented as only applying to the BBD30x devices. My guess is sending them is not actually a problem for other devices, but perhaps we should maintain them as optional somehow (e.g. default of None, which casues them to not be returned in the set) Certainly parsing should be tolerant of them being missing as the other devices might not actually return them...

Should not be too hard to do... I don't have this hardware (though have a KDC101 on order, so can test out to make sure it continues to work)

Gonna hold off on doing this until I have the hardware, but wanted to document a known change before I forgot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant