You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to propose the use of an explicit incidence structure separate from the Node objects. The current implementation of the Representation Graph uses lists of children in each collection node. I propose to introduce a data structure that holds all incidences in one place, closer to the spec, something like:
It is simple but not straightforward to do this refactoring because uses of the graph are spread over many modules (composer, representer, ...) and difficults the implementation of features such as anchors and recursive objects. This proposal will lead to improved code in general, such as avoiding creating and cleaning up state between calls to dumper and loader instances, and pave the way to feature completeness.
@Thom1729 I would appreciate your comments on this matter. I can work on a PR any time. Cheers!
The text was updated successfully, but these errors were encountered:
Hi everyone!
I want to propose the use of an explicit incidence structure separate from the
Node
objects. The current implementation of the Representation Graph uses lists of children in each collection node. I propose to introduce a data structure that holds all incidences in one place, closer to the spec, something like:It is simple but not straightforward to do this refactoring because uses of the graph are spread over many modules (composer, representer, ...) and difficults the implementation of features such as anchors and recursive objects. This proposal will lead to improved code in general, such as avoiding creating and cleaning up state between calls to
dumper
andloader
instances, and pave the way to feature completeness.@Thom1729 I would appreciate your comments on this matter. I can work on a PR any time. Cheers!
The text was updated successfully, but these errors were encountered: