Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mod versions when online-play #11555

Open
2 tasks done
AutumnPizazz opened this issue May 3, 2024 · 4 comments
Open
2 tasks done

Check mod versions when online-play #11555

AutumnPizazz opened this issue May 3, 2024 · 4 comments
Labels

Comments

@AutumnPizazz
Copy link
Contributor

AutumnPizazz commented May 3, 2024

Before creating

  • This is NOT a gameplay feature from Civ VI, BNW, or outside - see Roadmap
  • This is NOT a gameplay feature from Vanilla Civ V or from G&K - If so, it should be a comment in Missing features from Civ V - G&K #4697

Problem Description

We can add a version attribute to modOption.json, and check the version number during networking to enforce version consistency, which can avoid some errors.

Related Issue Links

No response

Desired Solution

Nothing.

Alternative Approaches

Nothing.

Additional Context

No response

@SomeTroglodyte
Copy link
Collaborator

Look for a closed PR - there was a version attribute, once upon a time, in some far away branch. Auto-set from release tags if the repo uses those, but free to edit otherwise... And already integrated into the when-to-update tests with fallback to timestamps if missing iirc...

@AutumnPizazz
Copy link
Contributor Author

What's the mean of Release Tag?
Unciv gets Mod in Release instead of Code Lib?

@SomeTroglodyte
Copy link
Collaborator

Means - look at lat-am: https://github.com/Caballero-Arepa/Latin-American_Civs/releases - we can query that stuff, and differentiate between repos that don't even have releases activated and those that use them... Then not load every last commit via the master/main/(whatever is marked as such) branch as zip, but load the release instead. Modder controls a little more directly when people update. Modder (or anyone else) can still test by feeding the branch zip URL to mod manager's explicit URL dialog.

PR was #10900 by the way

@AutumnPizazz
Copy link
Contributor Author

That's cool, however, I would like suggest that inforce players to have the same version when online. Has this function been okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants