Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: support aria-pressed attributes #4264

Open
anshuman-ms opened this issue May 8, 2024 · 0 comments
Open

Accessibility: support aria-pressed attributes #4264

anshuman-ms opened this issue May 8, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@anshuman-ms
Copy link

Please describe the feature that you want to propose

Based on Accessibility guidelines, buttons should not have interactive controls in it. https://dequeuniversity.com/rules/axe/4.5/nested-interactive

So, if we add any buttons or interactions using a custom node, then the accessibility compliance is hit. I checked with couple of my colleagues, and having a pressed state, might help.

When a node is selected it can probably be marked as aria-pressed="true" then the controls inside become interactive or else one other solution could be is to allow custom nodes to fully take over the a11y requirements. That means, not marking the node as button and letting the control inside handle accessibility. This is not possible today as selection is done via the role="button" div which is rendered and managed by React flow.

Any guidance or support will be appreciated

@anshuman-ms anshuman-ms added the feature request New feature or request label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant