Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls are just a white rectangle when using colorMode="dark" before rendering correctly #4262

Open
mcmxcdev opened this issue May 8, 2024 · 2 comments

Comments

@mcmxcdev
Copy link

mcmxcdev commented May 8, 2024

Describe the Bug

As the title indicates, the Controls shouldn't render a white box as long as the viewport is not fully ready.

Also, there is a white strip below the Controls which doesn't look like it's supposed to be there.

The Minimap on the other hand seems to be fine.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

I can provide reproduction steps tomorrow.

Expected behavior

Controls should probably not load too early and with the correct color scheme.

Screenshots or Videos

Screencast.from.2024-05-07.18-14-26.webm

Platform

Additional context

No response

@peterkogo
Copy link
Member

This is in Svelte Flow and with color mode "system", right?

@mcmxcdev
Copy link
Author

This is in Svelte Flow and with color mode "system", right?

Oh my bad, I forgot to mention that. We have a check like colorMode={isEmbed ? 'light' : $theme} in place, in this case colorMode resolves to "dark" so shouldn't render a white box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants