Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item count above table cuts off commas when updated via JS #1477

Open
cbirdsong opened this issue Apr 2, 2024 · 0 comments
Open

Item count above table cuts off commas when updated via JS #1477

cbirdsong opened this issue Apr 2, 2024 · 0 comments

Comments

@cbirdsong
Copy link

cbirdsong commented Apr 2, 2024

Bug Report

Expected Behavior

The item count should accurately reflect how many records are in Stream after it is updated with Javascript.

Actual Behavior

The item count is cut off at the first1 comma when it is updated with Javascript.

Steps to Reproduce the Problem

  1. Open the main Stream page (/wp-admin/admin.php?page=wp_stream) on a site with more than 999 items
  2. Look at the number next to the pagination buttons. (ex.: 21,403 items)
  3. Wait for something to happen elsewhere on the site that creates a record and updates the table.
  4. Look at the number again. It will be quite a bit smaller than it was in step 2.

Screenshots

I observed this on two different sites2:

CleanShot.2024-04-02.at.13.06.58.mp4
CleanShot.2024-04-02.at.13.14.00.mp4

System Information

  • Stream plugin version: 4.0.0
  • WordPress version: 6.4.3
  • PHP version: observed on both 7.4 and 8.x
  • Browser: Firefox
  • Computer operating system: MacOS

Footnotes

  1. I guess technically I don't know if it is the first or second comma since I don't have a site with 1,000,000 records handy. 🙃

  2. Both of these show exactly 165 pages, so I just double checked to verify that there is not also a problem with the "page X of Y" count. That number is working as expected on other sites, and these both being 165 is a ridiculous coincidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant