-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM Renderer: display underline when selection link content #4811
Comments
Regarding link handling the DOM renderer is pretty straight forward - it re-renders a line with underlines applied/remove from the linkifier events. A quickfix is prolly possible by internally eval'ing the selection state. A better long-term fix would involve changes on the linkifier, as the question here is, why it sends link events for selections in the first place. The mouse listeneners are quite scattered over the codebase currently, imho we would need a proper mouse listener service as a global orchestrator to fix this more reliably in the future. |
Fixed it, there is still an issue where the dashed line will not be visible. 🤪 |
20230918_222155.mp4
The text was updated successfully, but these errors were encountered: