Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xReg: issues with xReg (was discovery) #8

Closed
3 of 5 tasks
duglin opened this issue Apr 18, 2023 · 1 comment · Fixed by #185
Closed
3 of 5 tasks

xReg: issues with xReg (was discovery) #8

duglin opened this issue Apr 18, 2023 · 1 comment · Fixed by #185

Comments

@duglin
Copy link
Contributor

duglin commented Apr 18, 2023

These might still apply to xReg - need to check:

WIP

https://github.com/cloudevents/spec/blob/master/discovery.md#get-services

  • Any Service previously returned to a client that does not appear in this result can be assumed to be no longer available. I think this needs to be limited to just unfiltered queries since a missing entry from a filtered set could mean that it was deleted or that the filtered field changed.
  • Discovery endpoints MUST support filtering with the following attributes and MUST reject any unsupported filters. we should probably say what the HTTP response code is.
  • is Epoch allowed to be a negative int?
  • "name" must be non-empty string
  • typo: dataschama

Moved from: cloudevents/spec#863

@duglin
Copy link
Contributor Author

duglin commented Oct 30, 2024

I think we can close this one now.

  • first bullet we have There is no guarantee that a future GET to the COLLECTIONsurl will return the exact same collection since the contents of the Registry might have changed, add something like: The specification makes no statement as to whether a subsequent GET missing an entity means that it's been deleted or not.
  • second bullet will eventually be covered when we define what our errors look like: How prescriptive should we be about which HTTP error codes to return? #100

duglin added a commit to duglin/xreg-spec that referenced this issue Oct 30, 2024
- s/$json/$structure/g
- Support PATCH on collections
- s/GROUPs/GROUPS/g
- s/RESOURCEs/RESOURCES/g
- move ?model to ?inline=model, require ?nested on writes
- make no statement about 2nd GET missing entities meaning "deleted or not"

Fixes xregistry#8
Fixes xregistry#184
Fixes xregistry#182
Fixes xregistry#179

Signed-off-by: Doug Davis <[email protected]>
duglin added a commit to duglin/xreg-spec that referenced this issue Oct 30, 2024
- s/$json/$structure/g
- Support PATCH on collections
- s/GROUPs/GROUPS/g
- s/RESOURCEs/RESOURCES/g
- move ?model to ?inline=model, require ?nested on writes
- make no statement about 2nd GET missing entities meaning "deleted or not"

Fixes xregistry#8
Fixes xregistry#184
Fixes xregistry#182
Fixes xregistry#179

Signed-off-by: Doug Davis <[email protected]>
duglin added a commit to duglin/xreg-spec that referenced this issue Oct 30, 2024
- s/$json/$structure/g
- Support PATCH on collections
- s/GROUPs/GROUPS/g
- s/RESOURCEs/RESOURCES/g
- move ?model to ?inline=model, require ?nested on writes
- make no statement about 2nd GET missing entities meaning "deleted or not"

Fixes xregistry#8
Fixes xregistry#184
Fixes xregistry#182
Fixes xregistry#179

Signed-off-by: Doug Davis <[email protected]>
@duglin duglin closed this as completed in 8278f24 Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant