Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use ToEventStream as inputs #152

Open
CJ-Wright opened this issue Nov 29, 2018 · 0 comments
Open

Don't use ToEventStream as inputs #152

CJ-Wright opened this issue Nov 29, 2018 · 0 comments

Comments

@CJ-Wright
Copy link
Member

Currently when we walk up the graph we then walk down to check if the node has a ToEventStream subscribed to the node. If so we use that ToEventStream as our input uids allowing us to only cache that part of the pipeline. However this assumed that data which came out of a ToEventStream node was stored somewhere, which might not always be true. We could inspect if the ToEventStream node has a db.insert decedent, but that might be a bit brittle. Additionally this very funny walk might be more computationally expensive than calling nx.ancestors and looking for FromEventStream instances. (Note that this might be able to be mitigated by playing some fun graph games, maybe by searching the graph for all FromEventStream nodes and all ToEventStream nodes, looking at the paths to those nodes and finally making decisions based off the path (eg is the ToEventStream attached to a node on the path?)

tl;dr our magic for ToEventStream input tracking is nice, but maybe too smart for its own good. We might remove it to improve init time, simplicity, and developer sanity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant