Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page layout is unaligned and pages are not centered vertically #5268

Open
tmoerschell opened this issue Oct 21, 2023 · 1 comment · May be fixed by #5270
Open

Page layout is unaligned and pages are not centered vertically #5268

tmoerschell opened this issue Oct 21, 2023 · 1 comment · May be fixed by #5270
Labels
enhancement

Comments

@tmoerschell
Copy link
Contributor

Operating System

Linux

(Linux only) Distribution

openSUSE Tumbleweed

(Linux only) Desktop Environment

KDE Plasma

(Linux Only) Display Server

Wayland

Installation Method

Build from source

Xournal++ Version

xournalpp 1.2.1+dev (889aefd3)

libgtk Version

libgtk: 3.24.38

Bug Description

When pages of different sizes are layout in multiple rows, pages are not aligned as they should (there is some padding missing on the more narrow pages).
Additionally they are not centered vertically.

Expected Behaviour

All layout grid cells should be aligned, and pages should be centered horizontally and vertically within them.

Steps to Reproduce

  1. Set layout to 3-4 columns
  2. Open a document with different page sizes, eg. my beautiful physics notes
    not_really_pretty_layout

Additional Context

I have a fix ready. Looks like this:
better_layout
I know that horizontal alignement and vertical centering are kind of separate issues but I think it looks much nicer like this.
PR incoming
@tmoerschell tmoerschell linked a pull request Oct 21, 2023 that will close this issue
Open
@bhennion bhennion added enhancement and removed bug labels Oct 22, 2023
@tmoerschell
Copy link
Contributor Author

tmoerschell commented Nov 18, 2023 •
edited

I've been thinking about how this should best be solved. I suggest an option to choose between "grid" and "constant padding". I sketched how that would look. If someone could maybe give some feedback before I try to implement it all, it'd be greatly appreciated.
Layout.pdf
Note: page ordering would of course change between horizontal and vertical layout. I haven't depicted that accurately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create constant padding page layout option tmoerschell/xournalpp
2 participants
@bhennion @tmoerschell