New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: GitHub actions for simple PR checks #390

Open

DrMcCoy opened this issue Dec 6, 2018 · 0 comments

Labels

Member

DrMcCoy commented Dec 6, 2018

We should investigate whether GitHub Actions can be used for simple checks on pull requests.

For example, some style checks could be possible:

Trailing whitespace
Tab indenting
No space followed by a tab
#include "" needs to be with full paths (contains /), except for "config.h"
#include <> shouldn't begin with src/, and any of our third-party code
No "^{$"
if/while/switch... followed by a space
Correct indenting in rules.mk files
Commit message format (SUBSYSTEM: Foobar) and line lengths
...

(The style should mostly only be checked for files in src/, though)

Is there more that could possibly be checked? Can this be done with Actions at all? Will they work with force-pushes to the PR?

DrMcCoy added the infrastructure label

DrMcCoy mentioned this issue

GitHub services deprecation, replacements needed #326

Open

DrMcCoy mentioned this issue

Automated formatting #413

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment