ewmhFullscreen doesn't restore floating windows
#865
Comments
geekosaur
added a commit
to geekosaur/xmonad-contrib
that referenced
this issue
Jan 18, 2024
`EwmhFullscreen` unconditionally sinks windows in response to a `_NET_WM_STATE` root window message removing `_NET_WM_STATE_FULLSCREEN`. Unfortunately, at least some versions of either the Gtk or GNOME libraries send this on startup while restoring a window's last known state, which means a `manageHook` `doFloat` will be undone. This change ignores the remove if the window is not fullscreen. A followup issue, xmonad#865, has been added for the follow-on problem that the floating state of a window is not restored on removal of the fullscreen state. Fixes: xmonad#820
3 tasks
|
This could reasonably be parked until it matters to someone. Also, it's better not to try to address it until #866 goes in, since otherwise there will be a merge conflict. |
|
I believe #768 solved this already. |
|
"This commit only adds the hooks. Neither of the motivations are dealt with yet, so the docs are a bit terse still." |
|
Well that's the first commit. The following one adds the thing. |
geekosaur
added a commit
to geekosaur/xmonad-contrib
that referenced
this issue
Jan 19, 2024
`EwmhFullscreen` unconditionally sinks windows in response to a `_NET_WM_STATE` root window message removing `_NET_WM_STATE_FULLSCREEN`. Unfortunately, at least some versions of either the Gtk or GNOME libraries send this on startup while restoring a window's last known state, which means a `manageHook` `doFloat` will be undone. This change ignores the remove if the window is not fullscreen. A followup issue, xmonad#865, has been added for the follow-on problem that the floating state of a window is not restored on removal of the fullscreen state. Fixes: xmonad#820
geekosaur
added a commit
that referenced
this issue
Jan 21, 2024
`EwmhFullscreen` unconditionally sinks windows in response to a `_NET_WM_STATE` root window message removing `_NET_WM_STATE_FULLSCREEN`. Unfortunately, at least some versions of either the Gtk or GNOME libraries send this on startup while restoring a window's last known state, which means a `manageHook` `doFloat` will be undone. This change ignores the remove if the window is not fullscreen. A followup issue, #865, has been added for the follow-on problem that the floating state of a window is not restored on removal of the fullscreen state. Fixes: #820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If a floating window is made fullscreen and then toggled back, it is sunk instead of floated. The code at https://github.com/xmonad/xmonad-contrib/blob/afd6824ce00063bb8e9b7a1c5daf0737c2f61616/XMonad/Hooks/EwmhDesktops.hs#L442C5-L444 unconditionally sinks the window when
_NET_WM_STATE_FULLSCREENis removed.This will require saving the old window position for floats; the current code assumes sinking the window will handle positioning.
Checklist
I've read CONTRIBUTING.md
I tested my configuration
xmonadversion 0.17.2xmonad-contribversion 0.17.1The text was updated successfully, but these errors were encountered: