Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Changes #368

Open
denopink opened this issue Jan 25, 2023 · 0 comments
Open

API Changes #368

denopink opened this issue Jan 25, 2023 · 0 comments
Assignees
Labels

Comments

@denopink
Copy link
Contributor

denopink commented Jan 25, 2023

>= v0.8.3 (uber fx transition)

Overview

This ticket outlines the api updates from the transition from v0.7.6 (none uber fx implementation) to v0.8.3 (uber fx implementation).

API Changes

  • v2 endpoint behavior has change since upgrading to newer ancla and bascule releases
    • the validator GoodAlternativeURLs, now fails none existing hostnames for hook urls
      • this is caused by us not allowing AllowLoopback since that triggers a RejectLoopback check which does a net.LookupIP(host) triggering a dns error
    • rejection of auth token can return a 401 instead of a 403 or 400. For example, previously omitting the "Bearer" keyword would result in a 400 status code, whereas with this update, Tr1d1um will return a 401. Similarly, submitting "BeareR" before would result in a 403, now Tr1d1um will return a 401.

Affected Releases

Unaffected Releases

@denopink denopink pinned this issue Jan 25, 2023
@denopink denopink changed the title API Update: invalid URL hooks not support & auth status code(s) update API Changes Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants