-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove any logic specific to Device ID #229
Labels
Projects
Comments
Discussion with the team today led to these decisions:
Most of these decisions affect other repos. The main change needed for this issue is for Caduceus to no longer use the webhook |
kristinapathak
changed the title
Should Caduceus be responsible for knowing the device ID?
Remove any logic specific to Device ID
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, caduceus parses the device ID in two places:
caduceus/outboundSender.go
Line 582 in 453f141
caduceus/outboundSender.go
Line 391 in b2866f4
In talking with @schmidtw, we have reason to believe some consumers are using the device ID header, and we should probably keep that accurate. The part of the webhook struct that provides regex to apply against the device ID was more intended as a way to provide regex against the wrp.Source, so perhaps we could change the api to reflect that better without changing the Caduceus logic.
In our discussion, we didn't think Caduceus should be responsible for parsing the device ID from the event. Talaria knows the device ID already, so if it passes it to Caduceus, Caduceus could forward it - either as an http header or a new field in the wrp.
These are just options we discussed; further discussion is needed.
Update:
Given our discussion, these are the changes needed in Caduceus:
This is dependent on xmidt-org/wrp-go#53 and https://github.com/xmidt-org/webpa-common/issues/514.
The text was updated successfully, but these errors were encountered: