Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html: background color of the body-tag is respected only for the first snippet #21

Open
ralf3u opened this issue Nov 25, 2021 · 5 comments
Open

html: background color of the body-tag is respected only for the first snippet #21

ralf3u opened this issue Nov 25, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@ralf3u
Copy link

ralf3u commented Nov 25, 2021 

<body style="background:gray">

in preview.conf: snippet_html=true

tested with extra_css=extra-media.css and also tested with extra_css=disable
@xiota
Copy link
Owner

xiota commented Nov 25, 2021

That is because the beginning of the document with the style info gets cut off.

@ralf3u
Copy link
Author

ralf3u commented Nov 25, 2021

That is because the beginning of the document with the style info gets cut off.

So, instead of the code above, the alternative is to add the background color to the css in extra_css in preview.conf that works for all snippets. I'm fine with a wontfix-label on this issue that could be closed.

@xiota
Copy link
Owner

xiota commented Nov 25, 2021

I'm fine with a wontfix-label on this issue that could be closed.

I'll leave this open because I may look at it eventually. It's just that restructuring the plugin to make it more manageable would have to be done first.

@ralf3u
Copy link
Author

ralf3u commented Nov 26, 2021

It's just that restructuring the plugin to make it more manageable would have to be done first.

@xiota You don't need to fix issues for the actual plugin. I can wait for the redesigned plugin, because all important issues for my needs are fixed, and because I will not start to code in the next ten months. But I still publish issues, so you are informed, so you can maybe think about it to solve it in the redesigned plugin, and so you can test the issue later in the redesigned plugin.

If I recognize that it would be good to fix an issue soon, then I would ask you if it could be fixed in the next weeks.

@xiota
Copy link
Owner

xiota commented Nov 27, 2021

You don't need to fix issues for the actual plugin. I can wait for the redesigned plugin, because all important issues for my needs are fixed... But I still publish issues, so you are informed...

Thanks for reporting. Just wanted to let you know you're not being ignored.

If I recognize that it would be good to fix an issue soon, then I would ask you if it could be fixed in the next weeks.

That is helpful, like with the shaking problem. So I know what to prioritize.

@xiota xiota added the enhancement New feature or request label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiota @ralf3u