Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Your RMSE #2

Open
Padfoot-Luna opened this issue Oct 8, 2019 · 1 comment
Open

About Your RMSE #2

Padfoot-Luna opened this issue Oct 8, 2019 · 1 comment

Comments

@Padfoot-Luna
Copy link

Padfoot-Luna commented Oct 8, 2019

In CP_ALS and Tucker_ALS, why do you calculate the RMSE on the training set ( sparse_tensor) not on the test set as you do in BGCP?

Btw, final_mape = np.sum(np.abs(dense_tensor[pos] - tensor_hat[pos]) / dense_tensor[pos]) / dense_tensor[pos].shape[0], the np.abs() should cover (dense_tensor[pos] - tensor_hat[pos]) / dense_tensor[pos] instead of dense_tensor[pos] - tensor_hat[pos]

@xinychen
Copy link
Owner

This is a good question. Of course, you could replace that performance metric, and I will do that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants