fix eslint issues

Author: xibyte

.eslintrc.json

@@ -14,6 +14,13 @@
     "CSG" : true,
     "PNLTRI" : true,
     "__DEBUG__": true,
+    "__CAD_APP": true,
+    "Module": true,
+    "_free": true,
+    "_malloc": true,
+    "writeAsciiToMemory": true,
+    "__E0_ENGINE_EXCHANGE_VAL": true,
+    "verb": true,
     "$": true
   },
   "rules": {
@@ -22,5 +29,9 @@
     "max-len": "off",
     "no-console": "off",
     "no-extra-boolean-cast": "off"
-  }
+  },
+  "ignorePatterns": [
+    "/modules/math/optim/*.js",
+    "/modules/math/qr.js"
+  ]
 }

build/.eslintignore

@@ -182,7 +182,7 @@ function detectLoops(surface, graph) {
   BREP_DEBUG.startBooleanLoopDetection(graph);
   const loops = [];
   const seen = new Set();
-  while (true) {
+  for (;;) {
     let edge = graph.graphEdges.pop();
     if (!edge) {
       break;

modules/brep/operations/boolean-mesh.js

@@ -46,10 +46,6 @@ function distanceSqToSegment(a, b, pt) {
 
 export function solveClosestToCurveParamExactly(curve, pt, intMin, intMax, tol) {
 
-  function boundParam(u) {
-    return Math.min(max, Math.max(min, u));
-  }
-
   //solving minimization problem of squared distance 
 
   //f(u) = (fx(u) - x)^2 + (fy(u) - y)^2 + (fz(u) - z)^2 = fx^2 - 2*fx*x + x^2 ...  

modules/brep/operations/boolean.js

@@ -2,7 +2,7 @@ import {newtonIterationsOnInterval} from '../curves/newtonIterations';
 
 export function surfaceSurfaceStablePoints(surfaceA, surfaceB) {
 
-  function impl(surfaceA, surfaceB) {
+  function impl(curve) {
 
     //solving minimization problem of squared distance 
 
@@ -16,16 +16,18 @@ export function surfaceSurfaceStablePoints(surfaceA, surfaceB) {
 
       let [f, d1, d2] = curve.eval(u, 2);
 
-      let r1Comp = i => 2 * f[i] * d1[i] - 2 * pt[i] * d1[i];
-      let r2Comp = i => 2 * f[i] * d2[i] + 2 * d1[i] * d1[i] - 2 * pt[i] * d2[i];
+      let r1Comp = i => 2 * f[i] * d1[i] - 2 * f[i] * d1[i];
+      let r2Comp = i => 2 * f[i] * d2[i] + 2 * d1[i] * d1[i] - 2 * f[i] * d2[i];
 
       let r1 = r1Comp(X) + r1Comp(Y) + r1Comp(Z);
       let r2 = r2Comp(X) + r2Comp(Y) + r2Comp(Z);
 
       return [r1, r2];
     }
 
-    return newtonIterationsOnInterval(squareDistanceFn, intMin, intMax, tol);
+    let intMin = 0;
+    let intMax = 0;
+    return newtonIterationsOnInterval(squareDistanceFn, intMin, intMax, 1e-5);
 
   }
 

modules/brep/operations/polyhedronify.js

@@ -7,7 +7,7 @@
     "pack": "node ./node_modules/webpack/bin/webpack.js --config webpack.config.js --progress --profile --colors",
     "start-with-docs": "concurrently --kill-others 'npm start' './node_modules/grunt/bin/grunt docs-start'",
     "build": "grunt",
-    "lint": "./node_modules/eslint/bin/eslint web/app web/modules",
+    "lint": "./node_modules/eslint/bin/eslint.js web/app modules",
     "check-code": "./node_modules/typescript/bin/tsc --noEmit",
     "before-mainline-merging": "npm run lint && npm run check-code",
     "cypress": "npx cypress open"

modules/geom/curves/closestPoint.js

@@ -23,7 +23,7 @@ export function activate(context: ApplicationContext) {
 
   let showAnonymousActionHint = enableAnonymousActionHint(context);
 
-  function run(id: string, data: any): void {
+  function run(id: string, data?: any): void {
     let state = streams.action.state[id].value;
     let runner = runners[id];
     if (!state||!runner) {