From c2345a12ecb1b577abcbeb519b2c2c2350eea225 Mon Sep 17 00:00:00 2001
From: Cody Boone Ferguson <53008573+xexyl@users.noreply.github.com>
Date: Sat, 2 Nov 2024 06:15:16 -0700
Subject: [PATCH] Remove codeql.yml, .gitignore and Makefile

The reason it [codeql.yml] was removed before is that GitHub does not
support shell scripts. As such I have added codeql.yml to .gitignore.
The test.yml file will have to suffice.

The Makefile rules were reordered a bit and missing targets in .PHONY
were added (and also reordered).
---
 .github/workflows/codeql.yml | 54 ------------------------------------
 .gitignore                   |  1 +
 Makefile                     |  7 +++--
 3 files changed, 5 insertions(+), 57 deletions(-)
 delete mode 100644 .github/workflows/codeql.yml

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
deleted file mode 100644
index 3543eb5..0000000
--- a/.github/workflows/codeql.yml
+++ /dev/null
@@ -1,54 +0,0 @@
-name: "CodeQL Advanced"
-on:
-  push:
-    branches: [ "master" ]
-  pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [ "master" ]
-
-  workflow_dispatch:
-    branches: [ "master" ]
-  schedule: 
-    - cron: '18 15 * * 5'
-
-jobs:
-  analyze:
-    name: Analyze (${{ matrix.language }})
-    runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
-    permissions:
-      # required for all workflows
-      security-events: write
-
-      # required to fetch internal or private CodeQL packs
-      packages: read
-
-      # only required for workflows in private repositories
-      actions: read
-      contents: read
-
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-        - language: c-cpp
-          build-mode: autobuild
-    steps:
-    - name: Checkout repository
-      uses: actions/checkout@v4
-
-    # Initialises the CodeQL tools for scanning.
-    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3
-      with:
-        languages: ${{ matrix.language }}
-        build-mode: ${{ matrix.build-mode }}
-    - run: |
-       sudo apt-get install -y shellcheck
-       git clone https://github.com/lcn2/checknr.git
-       cd checknr && sudo make install
-       make test
-
-    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3
-      with:
-        category: "/language:${{matrix.language}}"
diff --git a/.gitignore b/.gitignore
index 71448de..5b464e8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,5 +2,6 @@
 *.bak
 *.bku
 .*.sw[a-z]
+/.github/workflows/codeql.yml
 readme.html
 README.html
diff --git a/Makefile b/Makefile
index 409bee0..e0dc2ee 100644
--- a/Makefile
+++ b/Makefile
@@ -61,7 +61,7 @@ RM_V=
 all:
 	@:
 
-.PHONY: all clean clobber install uninstall test check_man
+.PHONY: all clean clobber install uninstall shellcheck check_man test
 
 clean:
 	@:
@@ -120,8 +120,6 @@ shellcheck: ${SGIT} .shellcheckrc
 	@echo
 	@echo "${OUR_NAME}: make $@ ending"
 
-test: check_man shellcheck
-	@:
 
 check_man: ${ALL_MAN_TARGETS}
 	@echo
@@ -142,3 +140,6 @@ check_man: ${ALL_MAN_TARGETS}
 	fi
 	@echo
 	@echo "${OUR_NAME}: make $@ ending"
+
+test: shellcheck check_man
+	@: