Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Commit 527cda6

Browse files
jamesmontemagnojamesmontemagno
authored
GH-672: Update SMS recipient (#674)
* Add back constructor taking single recipient. * Update constructors * Clean up android xml * Update xamarin-essentials-android.xml
1 parent 2c2e6d6 commit 527cda6

File tree

7 files changed

+44
-6
lines changed

7 files changed

+44
-6
lines changed

‎Xamarin.Essentials/GlobalSuppressions.shared.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@
55

66
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "iOS is what we want.", Scope = "member", Target = "~P:Xamarin.Essentials.DevicePlatform.iOS")]
77
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("StyleCop.CSharp.NamingRules", "SA1300:Element should begin with upper-case letter", Justification = "iOS is what we want.", Scope = "member", Target = "~P:Xamarin.Essentials.DevicePlatform.iOS")]
8+
[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("StyleCop.CSharp.SpacingRules", "SA1008:Opening parenthesis should be spaced correctly", Justification = "Clashed with rule 1003", Scope = "member", Target = "~M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)")]

‎Xamarin.Essentials/Sms/Sms.shared.cs

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System;
2-
using System.Collections.Generic;
1+
using System.Collections.Generic;
32
using System.Linq;
43
using System.Threading.Tasks;
54

@@ -31,14 +30,24 @@ public SmsMessage()
3130
{
3231
}
3332

33+
public SmsMessage(string body, string recipient)
34+
{
35+
Body = body;
36+
if (!string.IsNullOrWhiteSpace(recipient))
37+
Recipients.Add(recipient);
38+
}
39+
3440
public SmsMessage(string body, IEnumerable<string> recipients)
3541
{
3642
Body = body;
37-
Recipients = recipients?.Where(x => !string.IsNullOrWhiteSpace(x)).ToList();
43+
if (recipients != null)
44+
{
45+
Recipients.AddRange(recipients.Where(x => !string.IsNullOrWhiteSpace(x)));
46+
}
3847
}
3948

4049
public string Body { get; set; }
4150

42-
public List<string> Recipients { get; set; }
51+
public List<string> Recipients { get; set; } = new List<string>();
4352
}
4453
}

‎docs/en/FrameworksIndex/xamarin-essentials-android.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@
526526
</Type>
527527
<Type Name="Xamarin.Essentials.SmsMessage" Id="T:Xamarin.Essentials.SmsMessage">
528528
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor" />
529+
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)" />
529530
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.Collections.Generic.IEnumerable{System.String})" />
530531
<Member Id="P:Xamarin.Essentials.SmsMessage.Body" />
531532
<Member Id="P:Xamarin.Essentials.SmsMessage.Recipients" />

‎docs/en/FrameworksIndex/xamarin-essentials-ios.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@
526526
<Type Name="Xamarin.Essentials.SmsMessage" Id="T:Xamarin.Essentials.SmsMessage">
527527
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor" />
528528
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.Collections.Generic.IEnumerable{System.String})" />
529+
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)" />
529530
<Member Id="P:Xamarin.Essentials.SmsMessage.Body" />
530531
<Member Id="P:Xamarin.Essentials.SmsMessage.Recipients" />
531532
</Type>

‎docs/en/FrameworksIndex/xamarin-essentials-uwp.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@
525525
<Type Name="Xamarin.Essentials.SmsMessage" Id="T:Xamarin.Essentials.SmsMessage">
526526
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor" />
527527
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.Collections.Generic.IEnumerable{System.String})" />
528+
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)" />
528529
<Member Id="P:Xamarin.Essentials.SmsMessage.Body" />
529530
<Member Id="P:Xamarin.Essentials.SmsMessage.Recipients" />
530531
</Type>

‎docs/en/FrameworksIndex/xamarin-essentials.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,7 @@
522522
<Type Name="Xamarin.Essentials.SmsMessage" Id="T:Xamarin.Essentials.SmsMessage">
523523
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor" />
524524
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.Collections.Generic.IEnumerable{System.String})" />
525+
<Member Id="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)" />
525526
<Member Id="P:Xamarin.Essentials.SmsMessage.Body" />
526527
<Member Id="P:Xamarin.Essentials.SmsMessage.Recipients" />
527528
</Type>

‎docs/en/Xamarin.Essentials/SmsMessage.xml

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,10 @@
2626
</AssemblyInfo>
2727
<Parameters />
2828
<Docs>
29-
<summary>To be added.</summary>
30-
<remarks>To be added.</remarks>
29+
<summary>Creates a new instance of SmsMessage</summary>
30+
<remarks>
31+
<para></para>
32+
</remarks>
3133
</Docs>
3234
</Member>
3335
<Member MemberName=".ctor">
@@ -47,6 +49,28 @@
4749
<param name="body">Content of the message</param>
4850
<param name="recipients">Recipients to receive the message.</param>
4951
<summary>Creates a new instance of SmsMessage</summary>
52+
<remarks>
53+
<para></para>
54+
</remarks>
55+
</Docs>
56+
</Member>
57+
<Member MemberName=".ctor">
58+
<MemberSignature Language="C#" Value="public SmsMessage (string body, string recipient);" />
59+
<MemberSignature Language="ILAsm" Value=".method public hidebysig specialname rtspecialname instance void .ctor(string body, string recipient) cil managed" />
60+
<MemberSignature Language="DocId" Value="M:Xamarin.Essentials.SmsMessage.#ctor(System.String,System.String)" />
61+
<MemberType>Constructor</MemberType>
62+
<AssemblyInfo>
63+
<AssemblyName>Xamarin.Essentials</AssemblyName>
64+
<AssemblyVersion>1.0.0.0</AssemblyVersion>
65+
</AssemblyInfo>
66+
<Parameters>
67+
<Parameter Name="body" Type="System.String" />
68+
<Parameter Name="recipient" Type="System.String" />
69+
</Parameters>
70+
<Docs>
71+
<param name="body">Content of the message</param>
72+
<param name="recipient">Recipient to receive the message.</param>
73+
<summary>Creates a new instance of SmsMessage</summary>
5074
<remarks>
5175
<para />
5276
</remarks>

0 commit comments

Comments
 (0)