Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Badge icon is stuck to the device's screen #60

Open
toussam opened this issue Nov 9, 2018 · 3 comments
Open

[Android] Badge icon is stuck to the device's screen #60

toussam opened this issue Nov 9, 2018 · 3 comments

Comments

@toussam
Copy link

toussam commented Nov 9, 2018

Hi,

I am using your package to set a badge icon internally and I mixed it with Xamarin's Android specification that is allowing the TabbedPage to be set at the bottom.

The badge icon is working great, but on Android devices this last one is almost stuck to the device's screen. I checkout your wiki and I know we can change its position (TopLeft, BottomLeft, etc..), but in my case I simply would like to keep at the TopRight (default value) and be more on the related icon (like on iOS devices).

Could you allow us set a more precise position for the badge or set it more closer to the related icon ? I am sharing you some screenshots to illustrate my saying. :)

I thank you in advance for everything and wish you a great weekend !
Best regards,

Screenshots.zip

EDIT: this case is happening since I applied the badge to the lefty tab's children and only when this last one being selected.

@toussam toussam changed the title [Android] Badge icon of the lefty tab's children is stuck to the device's screen [Android] Badge icon is stuck to the device's screen Nov 9, 2018
@xabre
Copy link
Owner

xabre commented Nov 11, 2018

@toussam Use the BadgeMargin property to fine tune the position on android ;) Run the sample app to see how this influences the badge position.

@xabre xabre added the question label Nov 11, 2018
@Romain1Lambert
Copy link

Hey @xabre !
It worked well.
I noticed that with a bottom TabbedPage
android:TabbedPage.ToolbarPlacement="Bottom"

The classic xamarin behavior changes the position of the Icon but the badge stays at the same position. It makes the badge on a different place compared to the icon wether you have the focus on the Content page or not.

I implemented my own fix with different margins when you leave or enter the page.
I tought handling this behavior in your plugin could be a nice improvement for futur developpers!

Best regards.

@toussam
Copy link
Author

toussam commented Dec 13, 2018

Hi @xabre ,

Could you help us with this issue ? We would like to remove our temporary fix in the future hoping your package will handle such by itself. :)

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants