Skip to content

Reloading config wipes all user added comments #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dangles opened this issue Feb 4, 2025 · 1 comment
Open

Reloading config wipes all user added comments #260

Dangles opened this issue Feb 4, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Dangles
Copy link

Dangles commented Feb 4, 2025

Make it so that comments left in the config are ignored when the plugin loads. For example, I translated some original comments into native language via neural network for convenience, but after reloading everything is reset. Also reset my comments if I left them. For example, I want to comment out an old value in some parameter so I can go back to it, but I can't do that because the plugin will update everything after the server reboot.

Translated with DeepL.com (free version)

@xGinko xGinko added the enhancement New feature or request label Mar 17, 2025
@xGinko
Copy link
Owner

xGinko commented Mar 17, 2025

This happens because AEF technically rebuilds the config on load/reload.

The whole reason for doing it that way is because it simplifies the process of updating everything in the config (info comments change / get updated with better info, config sections get optimized/changed).
However, I agree it is not an optimal solution.

Will get looked into but lower prio for now

@xGinko xGinko changed the title Ignore config comments Change config load behavior to not wipe content Mar 17, 2025
@xGinko xGinko changed the title Change config load behavior to not wipe content Reloading config wipes all user added comments Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants