Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: static configuration to reference subgraphs by name rather than index #683

Open
flymedllva opened this issue Apr 3, 2024 · 7 comments
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.

Comments

@flymedllva
Copy link
Contributor

Component(s)

router

Is your feature request related to a problem? Please describe.

I use wgc to build the schematic locally and I get Failed to fetch from subgraph '7' at path 'query'., it is not clear what this subgraph is.

Describe the solution you'd like

I would like to be able to see the name of the subgraph in the bug despite the fact that it reveals information about the services under the router.

Describe alternatives you've considered

No response

Additional context

No response

@flymedllva flymedllva added the enhancement New feature or request label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

@Aenimus
Copy link
Member

Aenimus commented Apr 3, 2024

Please can you attach your .yml that you're passing to wgc router compose?

@flymedllva
Copy link
Contributor Author

flymedllva commented Apr 3, 2024

it numbers all the listed services, I would like to see the name in the error, not the number.

version: 1
subgraphs:
  - name: test
    routing_url: http://localhost:8080/query
    introspection:
      url: http://localhost:8080/query

@flymedllva
Copy link
Contributor Author

flymedllva commented Apr 3, 2024

For example see screens from #684

I would like to see the name of the graph "test" in the error, not "0".

@Aenimus
Copy link
Member

Aenimus commented Apr 3, 2024

For the error you've posted here, you have >=8 subgraphs, correct?

And the issue is that subgraph provides the index, rather than the name?

@Aenimus
Copy link
Member

Aenimus commented Apr 3, 2024

When using a static config, indices are used. See also: #364

We'd welcome a PR that addresses this, but changing it is not a priority.

@Aenimus Aenimus changed the title Failed to fetch from Subgraph static configuration references subgraphs by index rather than name Apr 3, 2024
@Aenimus Aenimus changed the title static configuration references subgraphs by index rather than name request: static configuration to reference subgraphs by name rather than index Apr 3, 2024
@flymedllva
Copy link
Contributor Author

For the error you've posted here, you have >=8 subgraphs, correct?

And the issue is that subgraph provides the index, rather than the name?

Yes, more than 25 subgraphs so far.

When using a static config, indices are used. See also: #364

We'd welcome a PR that addresses this, but changing it is not a priority.

Yeah in trace would be cool to see the name too!

Thx

@Aenimus Aenimus added the internally-reviewed The issue has been reviewed internally. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

No branches or pull requests

2 participants