-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for response compression #602
Comments
WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible. |
/bounty $200 |
|
/attempt #602 Options |
@StarpTech do we need prehandler and posthandler to decode and encode the request body? |
/attempt #602
|
💡 @Rutik7066 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
Hi @StarpTech I have raised the draft PR. I would appreciate your help with further development. I need to know where I should use compression and decompression functions to achieve the desired results. |
Hi @Rutik7066, I really like your ambitions but please respect the bounty requirements. We picked small tasks which should be solved alone. If you believe this task is too complicated, please move on with another one.
|
Hi @StarpTech I need you help in architectural understanding in know in I have to add it as prehandler and posthandler. But I am unable to understand where other prehandler and posthandler is added. |
@Rutik7066 take a look at the referenced issue #153 We want to support client response compression. This means, a middleware needs to be implemented that overwrites responseWriter to support the compression algorithm. You can use https://github.com/go-chi/chi/blob/master/middleware/compress.go |
Got it 🫡 |
Hi @StarpTech work is completed. Could you please review PR |
I'm interested in taking a shot at this, adding my name to the queue! |
PR submitted already everything is done. I am waiting for @StarpTech to review the PR |
Hi @StarpTech could you please review the PR |
Hi @Rutik7066 , there is a lot going on right now. I promise to review it at the beginning of next week. Thank you for your patience. |
🎉🎈 @Rutik7066 has been awarded $100! 🎈🎊 |
I have decreased the scope of the ticket and therefore also the reward. Thanks for the contribution @Rutik7066 |
@StarpTech what? |
@StarpTech I think you know I worked because of 200$ bounty price right. If anything from my side needs to be corrected or completed then you should tell me instead of this thing. |
Hi @Rutik7066, I appreciate the effort you put into the project. However, it's important to note that the requirements were clearly outlined from the start. We've provided significant guidance throughout this process, which wasn't the intent of the bounty. You have completed response compression, which is only half of the requirement, and therefore received $100 as a reward. The issue is closed. Thank you for your understanding and contribution. |
Component(s)
router
Is your feature request related to a problem? Please describe.
As a user, I'd like to be able to compress data between the client <-> router to save bandwidth and improve performance.
Describe the solution you'd like
Response compression is done transparently. The user of the router doesn't need to configure anything. The exchange is done through HTTP headers
Accept-Encoding
. The implementation should support Gzip, Deflate and Brotli as compression methods.We need to extend the router to compress responses. A very reasonable choice for gzip could be https://github.com/klauspost/compress/tree/master/gzhttp which also serve as good inspiration for the other methods.
Requirements:
Describe alternatives you've considered
No response
Additional context
We use gin as http framework. The router engine transport can be found here https://github.com/wundergraph/cosmo/blob/main/router/core/transport.go
Previous issue #153
The text was updated successfully, but these errors were encountered: