New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonicalize NaNs #20

Open

rvolosatovs opened this issue Apr 23, 2024 · 0 comments

Labels

enhancement go good first issue help wanted rust

Milestone

feature-completeness

Collaborator

rvolosatovs commented Apr 23, 2024 •

edited

floating point number NaNs have exactly one canonical representation in component-model specification, which we should match to be compliant.

Basically this is about adapting https://github.com/WebAssembly/component-model/blob/c3ef2a99f7c70b8189a889314569c0ce38c0433b/design/mvp/canonical-abi/definitions.py#L415-L441 in float encoding (although I do think we can be more lenient of decoding side and accept any NaN)

Refs WebAssembly/component-model#336 (comment)

rvolosatovs added this to the feature-completeness milestone

rvolosatovs added enhancement good first issue labels

rvolosatovs added help wanted golang rust labels

rvolosatovs added go and removed golang labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment