-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use socket file for HTTP with --init-db
nor db migrate
#790
Comments
Updated repro for 0.15.0. This causes upgrades (db migrations) to print an error and Should being unable to delete the socket file be a fatal error? Or can paths that don't set up the listener, and aren't supposed to set up the listener, be changed to not try to remove it?
|
Describe the bug
v0.14.0 added the ability to listen on a Unix socket, but it is not possible to reproducibly/cleanly use it (i.e. in a docker container) because
--init-db
anddb migrate
fail because they both callshutdown()
which tries to remove the socket file that was never set up.writefreely/app.go
Line 732 in 4aad033
writefreely/app.go
Line 744 in 4aad033
Other locations may also do this (ResetPassword?).
Steps to reproduce (if necessary)
Start from a clean directory/image - example:
docker run -it --rm ubuntu:22.04
Run the following to reliably reproduce:
The important part being: create a config that uses a socket file, then try to initialize the database.
Alternate repro: take an existing working setup that uses a socket, and try to run
writefreely db migrate
.The logs in the migrate case are shorter and look like this:
Expected behavior
writefreely starts up using a socket for HTTP connections. db migrations/inits don't fail on a missing HTTP socket file.
Application configuration
Version or last commit:
0.14.0
cc: @clarfonthey
The text was updated successfully, but these errors were encountered: