Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider use of 'wp_localize_string' #36

Open
NielsdeBlaauw opened this issue Mar 13, 2019 · 0 comments
Open

Reconsider use of 'wp_localize_string' #36

NielsdeBlaauw opened this issue Mar 13, 2019 · 0 comments
Labels

Comments

@NielsdeBlaauw
Copy link
Collaborator

There a lot of calls like this in the code:

wp_localize_script( PostmanViewController::POSTMAN_SCRIPT, 'postman_input_basic_password', '#input_' . PostmanOptions::BASIC_AUTH_PASSWORD );

The third argument should be an array, but the bigger problem is this feels like abuse of the localize function to do something the script should do itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant