Support SPM installation #1379
Open
Support SPM installation #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenhumphreys
commented
Dec 5, 2023
| @@ -967,8 +967,7 @@ | |||
| F1DC21B22199D58B007C189E /* ElementToAttributedString */, | |||
| F1E75630215B0C9E004BC254 /* StringAttributesToAttributes */, | |||
| ); | |||
| name = Converters; | |||
| path = "New Group"; | |||
| path = Converters; | |||
There was a problem hiding this comment.
I noticed that this group was not properly renamed on disk and renamed it so it shows up correctly in SPM.
allenhumphreys
commented
Dec 5, 2023
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
allenhumphreys
commented
Dec 5, 2023
There was a problem hiding this comment.
This file is not part of the Xcode project, but SPM was picking it up and failing to compile.
|
I just want to say thanks for the awesome library. I know I didn't ask about adding this support before opening the PR, it's ok if this doesn't align with your goal, though. I had trouble finding your project when looking to solve what this solves, and I'd love to get it listed in the swift package index if this goes through. |
allenhumphreys
force-pushed
the
ah/spm
branch
from
aaeb244
to
1719ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1372 #1370
To test:
You can add
.package(url: "https://github.com/allenhumphreys/AztecEditor-iOS", branch: "ah/spm")to the dependencies in a sample application. If needed I can create a repo with a sample application that consumes the package.CHANGELOG.mdif necessary.