Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than 16KB to be encoded #68

Open
layderv opened this issue Dec 13, 2021 · 2 comments
Open

Allow more than 16KB to be encoded #68

layderv opened this issue Dec 13, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@layderv
Copy link
Contributor

layderv commented Dec 13, 2021

As per your README, the tool does not allow to store more than 16KB (header included).

How do you see this changed? A simple u16->u64 change? Is a version dump required (I'd say so)?

@woodruffw
Copy link
Owner

Yeah, we should bump STEG86_VERSION and consequently STEG86_MAX_CAPACITY_BYTES and STEG86_HEADER_SIZE_BITS.

I'd suggest changing it to just u32 instead of u64 for now, since it's unlikely that we'll see any real-world x86 binaries that come even close to exceeding 2.4GB of steganography capacity 🙂

@woodruffw
Copy link
Owner

(Also, it'd be ideal if we could preserve compatibility with the old header in the codebase. But if you look into it and it's a hassle, we can just spit out an error telling people to use an earlier version.)

@woodruffw woodruffw added enhancement New feature or request help wanted Extra attention is needed labels Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants