Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nil pointer with invalid id on trigger pipeline api #3686

Closed
3 tasks done
gamingdy opened this issue May 6, 2024 · 0 comments · Fixed by #3688
Closed
3 tasks done

Nil pointer with invalid id on trigger pipeline api #3686

gamingdy opened this issue May 6, 2024 · 0 comments · Fixed by #3688
Labels
bug Something isn't working server

Comments

@gamingdy
Copy link
Contributor

gamingdy commented May 6, 2024

Component

server

Describe the bug

When I tried to trigger a pipeline via api with an incorrect ID, I got an error 500 instead of 404, because it doesn't check if there is a repo with the given ID

The following route:
https://my-woodpecker/api/repos/{repo_id}/pipelines

Sorry in advance if this is a duplication of issues, in searching I found no issues with my keywords

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.4.1"}

Additional context

image

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@gamingdy gamingdy added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants