Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATOM feed elements whose updated date changes should be reported as changing #102

Open
olberger opened this issue Jun 23, 2017 · 1 comment

Comments

@olberger
Copy link

olberger commented Jun 23, 2017

When an atom feed element has an "updated" date which changes, it should be taken into account, in addition to the content's value, for detecting a modified element that needs to be notified.

The following provides such capacity:

diff --git a/rss2email/feed.py b/rss2email/feed.py
index a5d76ae..cb6c0f1 100644
--- a/rss2email/feed.py
+++ b/rss2email/feed.py
@@ -514,6 +514,9 @@ class Feed (object):
                 return entry.id
         content = self._get_entry_content(entry)
         content_value = content['value'].strip()
+        updated = getattr(entry, 'updated', None)
+        if updated:
+            content_value += entry.updated
         if content_value:
             return _hashlib.sha1(
                 content_value.encode('unicode-escape')).hexdigest()
@Ekleog
Copy link

Ekleog commented Sep 11, 2020

Hello,

This repository has been deprecated for a few years now, and has been replaced by https://github.com/rss2email/rss2email .

If this issue is still relevant to you, and not fixed with v3.12.2, could you please reopen the issue there?

Cheers,
Leo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants