Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to change badgeTextColor for bottomTab #6889

Closed
lindesvard opened this issue Jan 8, 2021 · 1 comment 路 May be fixed by #6973
Closed

Add option to change badgeTextColor for bottomTab #6889

lindesvard opened this issue Jan 8, 2021 · 1 comment 路 May be fixed by #6973
Assignees
@mateioprea @swabbass
Labels
platform: Android platform: iOS type: accepted/enhancement
Projects
React Native Navigation

Comments

@lindesvard
Copy link
Contributor

馃殌 Feature

I don't think this option exists (but can't find it in the documentation). Would be nice to be able to change the text color for the bottom tab badge. Seems like we only can change the background color?

So basically add a option like badgeTextColor to bottomTab-options.

Have you read the Contributing Guidelines on issues?

Yes

Motivation/Pitch

We have a fairly light badge color and together with the white text color causing poor a11y compliance. We could off course increase the background color but I think this option would be appreciated by others as well.
@danilobuerger
Copy link
Collaborator

This should preferably be implemented inside a badge object option, for example:

badge: {
  value: "...", // old badge option
  color: "...", // new proposed option
  backgroundColor: "...", // old badgeColor option
}

@mateioprea mateioprea self-assigned this Jan 8, 2021
@swabbass swabbass mentioned this issue Feb 18, 2021
Draft
@swabbass swabbass self-assigned this Feb 18, 2021
@swabbass swabbass added this to In Progress in React Native Navigation Feb 18, 2021
React Native Navigation automation moved this from In Progress to Done Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateioprea mateioprea

@swabbass swabbass

Labels
platform: Android platform: iOS type: accepted/enhancement
Projects
React Native Navigation
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bottom tab Badge style wix/react-native-navigation
4 participants
@danilobuerger @mateioprea @lindesvard @swabbass